remove unused procedure and middleware #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 261 Passed, 36 Skipped, 49.1s Total Time |
adriangohjw
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Removed unused
nonStrictAuthMiddlewareandagnosticProcedurefrom the tRPC configuration.What changed?
nonStrictAuthMiddlewaremiddleware function that was handling cases where users were deleted but had active sessionsagnosticProcedureexport that utilized the removed middlewareHow to test?
agnosticProcedureWhy make this change?
The
nonStrictAuthMiddlewareandagnosticProcedurewere not being used in the application, making them unnecessary code that could cause confusion. Removing unused code improves maintainability and reduces the potential for security issues from unused authentication paths.